Guard all our lambdas with SafePointers #6560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a bunch of lambdas which referenced 'this' rather than 'that = SafePointer' for callbacks on timers and I think perhaps one of those is what caused the very occasional crash-on close in reaper reported in surge-synthesizer#6558 so review them and push a change. Keep the issue open for a bit while we look for crashes tho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bunch of lambdas which referenced 'this' rather than
'that = SafePointer' for callbacks on timers and I think
perhaps one of those is what caused the very occasional crash-on
close in reaper reported in #6421 so review them and push a change.
Keep the issue open for a bit while we look for crashes tho